Add support for tentative return types of internal methods #6971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
commented
May 11, 2021
nikic
reviewed
May 11, 2021
Zend/tests/type_declarations/variance/internal_parent/internal_parent.phpt
Outdated
Show resolved
Hide resolved
|
Something you might want to consider is moving the tentative flag into ZEND_ACC_TENTATIVE_RETURN_TYPE -- at least I find the asymmetry between the two flags a bit odd. |
kocsismate
force-pushed
the
tentative-return-type-1
branch
from
99139e8 to
b96379f
Compare
I've just searched for Or I just misunderstood you? |
nikic
approved these changes
May 14, 2021
kocsismate
added a commit
that referenced
this pull request
May 14, 2021
|
Closed via 532c60c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/internal_method_return_types
First part of #6548